Skip to content

Commit

Permalink
fix: phantom dependency (#223)
Browse files Browse the repository at this point in the history
<!--
Thank you for your pull request. Please review below requirements.
Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md

感谢您贡献代码。请确认下列 checklist 的完成情况。
Bug 修复和新功能必须包含测试,必要时请附上性能测试。
Contributors guide:
https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to
[x]. -->

- [ ] `npm test` passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines

##### Affected core subsystem(s)
<!-- Provide affected core subsystem(s). -->


##### Description of change
<!-- Provide a description of the change below this comment. -->

<!--
- any feature?
- close https://github.com/eggjs/egg/ISSUE_URL
-->
  • Loading branch information
gxkl authored May 28, 2024
1 parent 5b996a0 commit 9bdd1ec
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [ 14, 16, 18 ]
node-version: [ 16, 18, 20 ]
steps:
- name: Checkout Git Source
uses: actions/checkout@master
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [ 14, 16, 18 ]
node-version: [ 16, 18, 20 ]
steps:
- name: Checkout Git Source
uses: actions/checkout@master
Expand All @@ -67,7 +67,8 @@ jobs:
run: brew install [email protected]

- name: Start Mysql
run: /usr/local/opt/[email protected]/bin/mysql.server start
## arm64/x86 homebrew mysql path different
run: /usr/local/opt/[email protected]/bin/mysql.server start || /opt/homebrew/Cellar/[email protected]/5.7.44_1/bin/mysql.server start

- name: Install Npm
run: npm i -g npm@9
Expand All @@ -88,7 +89,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [ 14, 16, 18 ]
node-version: [ 16, 18, 20 ]
steps:
- name: Checkout Git Source
uses: actions/checkout@master
Expand Down
2 changes: 1 addition & 1 deletion plugin/controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
},
"dependencies": {
"@eggjs/egg-module-common": "^1.0.0",
"@eggjs/router": "^2.0.0",
"@eggjs/tegg": "^1.6.5",
"@eggjs/tegg-common-util": "^1.2.3",
"@eggjs/tegg-loader": "^1.4.4",
Expand All @@ -61,7 +62,6 @@
},
"devDependencies": {
"@eggjs/module-test-util": "^1.4.4",
"@eggjs/router": "^2.0.0",
"@eggjs/tegg-config": "^1.3.3",
"@eggjs/tegg-plugin": "^1.5.6",
"egg": "^2.26.0",
Expand Down
3 changes: 1 addition & 2 deletions plugin/orm/lib/LeoricRegister.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import Base from 'sdk-base';
import { ModelProtoManager } from './ModelProtoManager';
import { DataSourceManager, OrmConfig } from './DataSourceManager';
import Realm from 'leoric';
import { hookNames } from 'leoric/src/setup_hooks';
import Realm, { hookNames } from 'leoric';
import { ModelMetadata, ModelMetadataUtil } from '@eggjs/tegg-orm-decorator';

export class LeoricRegister extends Base {
Expand Down

0 comments on commit 9bdd1ec

Please sign in to comment.