Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper to get EggObject from class #148

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 28, 2023

No description provided.

@fengmk2 fengmk2 added the enhancement New feature or request label Aug 28, 2023
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02% ⚠️

Comparison is base (f049412) 93.79% compared to head (7f427cf) 93.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   93.79%   93.77%   -0.02%     
==========================================
  Files         228      228              
  Lines        4815     4821       +6     
  Branches      526      527       +1     
==========================================
+ Hits         4516     4521       +5     
- Misses        299      300       +1     
Files Changed Coverage Δ
core/runtime/src/factory/EggContainerFactory.ts 93.33% <83.33%> (-2.50%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 added this pull request to the merge queue Aug 28, 2023
Merged via the queue into master with commit 77eaf38 Aug 28, 2023
@fengmk2 fengmk2 deleted the get-object-from-class branch August 28, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants