Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support load module config with env #151

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Sep 7, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu force-pushed the feat/module_config_env branch from 88fd0c6 to 6268ebc Compare September 7, 2023 08:06
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killagu killagu force-pushed the feat/module_config_env branch from bd7bb5f to 96bd434 Compare September 7, 2023 08:38
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 68.75% and project coverage change: -0.06% ⚠️

Comparison is base (398549c) 92.49% compared to head (96bd434) 92.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   92.49%   92.44%   -0.06%     
==========================================
  Files         230      230              
  Lines        4878     4897      +19     
  Branches      538      543       +5     
==========================================
+ Hits         4512     4527      +15     
- Misses        366      370       +4     
Files Changed Coverage Δ
core/common-util/src/ModuleConfig.ts 75.47% <66.66%> (+0.29%) ⬆️
plugin/config/app.ts 100.00% <100.00%> (ø)
standalone/standalone/src/Runner.ts 93.45% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu added this pull request to the merge queue Sep 7, 2023
Merged via the queue into master with commit c087226 Sep 7, 2023
14 of 17 checks passed
@killagu killagu deleted the feat/module_config_env branch September 7, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants