Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto set name and env on runtimeConfig #152

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 12, 2023

No description provided.

@fengmk2 fengmk2 added the enhancement New feature or request label Sep 12, 2023
@fengmk2 fengmk2 requested review from popomore and killagu September 12, 2023 06:23
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a30835c) 92.44% compared to head (cf38ba3) 92.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   92.44%   92.44%           
=======================================
  Files         230      230           
  Lines        4897     4898    +1     
  Branches      543      544    +1     
=======================================
+ Hits         4527     4528    +1     
  Misses        370      370           
Files Changed Coverage Δ
standalone/standalone/src/Runner.ts 93.51% <100.00%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into master with commit 870f1e0 Sep 12, 2023
17 checks passed
@fengmk2 fengmk2 deleted the set-name-and-env branch September 12, 2023 07:57
@fengmk2
Copy link
Member Author

fengmk2 commented Sep 12, 2023

Successfully published:
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
lerna success published 28 packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants