Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support dependency module for standalone #155

Merged
merged 1 commit into from
Sep 18, 2023
Merged

feat: support dependency module for standalone #155

merged 1 commit into from
Sep 18, 2023

Conversation

gxkl
Copy link
Contributor

@gxkl gxkl commented Sep 18, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gxkl gxkl force-pushed the feat/module-dependency branch from 483d6e7 to ec79356 Compare September 18, 2023 01:21
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ea75fdc) 92.44% compared to head (ec79356) 92.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   92.44%   92.45%           
=======================================
  Files         230      230           
  Lines        4900     4903    +3     
  Branches      518      520    +2     
=======================================
+ Hits         4530     4533    +3     
  Misses        370      370
Files Changed Coverage Δ
standalone/standalone/src/Runner.ts 93.80% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gxkl gxkl requested review from killagu and fengmk2 September 18, 2023 01:36
@fengmk2 fengmk2 added this pull request to the merge queue Sep 18, 2023
Merged via the queue into master with commit df2e2a6 Sep 18, 2023
@fengmk2 fengmk2 deleted the feat/module-dependency branch September 18, 2023 02:04
killagu
killagu approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gxkl
Copy link
Contributor Author

gxkl commented Sep 18, 2023

Successfully published:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gxkl @fengmk2 @killagu