Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo acL to acl #156

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: typo acL to acl #156

merged 1 commit into from
Sep 20, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Sep 18, 2023 •
edited
Loading

No description provided.

@fengmk2 fengmk2 requested a review from killagu September 18, 2023 16:19
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (648b5fc) 92.45% compared to head (4627289) 92.45%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         230      230           
  Lines        4903     4903           
  Branches      520      520           
=======================================
  Hits         4533     4533           
  Misses        370      370
Files Changed Coverage Δ
...ntroller-decorator/src/model/HTTPControllerMeta.ts 100.00% <100.00%> (ø)
...e/controller-decorator/src/model/HTTPMethodMeta.ts 95.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

killagu
killagu approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2023
@killagu killagu added this pull request to the merge queue Sep 20, 2023
@killagu killagu removed this pull request from the merge queue due to a manual request Sep 20, 2023
@killagu killagu merged commit a775d34 into master Sep 20, 2023
17 checks passed
@killagu killagu deleted the type-acL branch September 20, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengmk2 @killagu