Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add className property to EggPrototypeInfo #158

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: add className property to EggPrototypeInfo #158

merged 3 commits into from
Sep 20, 2023

Conversation

popomore
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from killagu September 19, 2023 13:13
@popomore
Copy link
Member Author

除了 innerObject，应该都有 className

killagu
killagu approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu
Copy link
Contributor

killagu commented Sep 19, 2023

CI 需要修复一下。

@popomore popomore force-pushed the feat/Prototype-className branch from cb4d424 to f9c0cce Compare September 19, 2023 13:28
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02% ⚠️

Comparison is base (648b5fc) 92.45% compared to head (dc05696) 92.43%.

❗ Current head dc05696 differs from pull request most recent head 50f3da2. Consider uploading reports for the commit 50f3da2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   92.45%   92.43%   -0.02%     
==========================================
  Files         230      230              
  Lines        4903     4907       +4     
  Branches      520      520              
==========================================
+ Hits         4533     4536       +3     
- Misses        370      371       +1
Files Changed Coverage Δ
...core-decorator/src/decorator/MultiInstanceProto.ts 100.00% <ø> (ø)
core/core-decorator/src/decorator/Prototype.ts 100.00% <ø> (ø)
...metadata/src/factory/EggPrototypeCreatorFactory.ts 93.10% <ø> (ø)
core/metadata/src/model/EggPrototype.ts 100.00% <ø> (ø)
...alone/standalone/src/StandaloneInnerObjectProto.ts 66.66% <66.66%> (-1.08%) ⬇️
core/metadata/src/impl/EggPrototypeBuilder.ts 87.71% <100.00%> (+0.21%) ⬆️
core/metadata/src/impl/EggPrototypeImpl.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popomore
Copy link
Member Author

popomore commented Sep 19, 2023 •
edited
Loading

@killagu 我把 innerObject 的 className 定义也去掉了，现在没传入所以不用实现了。

@killagu killagu added this pull request to the merge queue Sep 20, 2023
@killagu killagu removed this pull request from the merge queue due to a manual request Sep 20, 2023
@killagu killagu merged commit bddac97 into master Sep 20, 2023
15 checks passed
@killagu killagu deleted the feat/Prototype-className branch September 20, 2023 01:54
@killagu
Copy link
Contributor

killagu commented Sep 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popomore @killagu