Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set plugin module optional false if be enabled as a plugin #190

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Feb 19, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8156bb9) 94.01% compared to head (34d13ea) 94.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   94.01%   94.02%           
=======================================
  Files         236      236           
  Lines        5029     5034    +5     
  Branches      543      545    +2     
=======================================
+ Hits         4728     4733    +5     
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gxkl gxkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 57a1adc into master Feb 19, 2024
19 checks passed
@killagu killagu deleted the feat/plugin_module branch February 19, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants