Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use @eggjs/ajv-keywords and @eggjs/ajv-formats #204

Merged
merged 3 commits into from
Apr 7, 2024
Merged

fix: use @eggjs/ajv-keywords and @eggjs/ajv-formats #204

merged 3 commits into from
Apr 7, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 7, 2024 •
edited
Loading

Summary by CodeRabbit

  • Chores
    • Updated the dependency for keyword validation in the plugin system to improve stability and compatibility.
    • Added the ajv package as a new dev dependency in package.json.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 7, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 21f44b5 and d173035.

Walkthrough

The update involves a significant change in the AJV plugin's configuration, specifically in how keywords are imported and managed. The modification transitions the source of the keyWords module from the standalone ajv-keywords package to a new, presumably more integrated package under the @eggjs namespace, named @eggjs/ajv-keywords. This shift not only reflects a change in dependency management but also potentially aligns with broader ecosystem or organizational preferences.

Changes

Files Change Summary
plugin/ajv/lib/Ajv.ts, plugin/ajv/package.json Updated import statement and dependency reference for keyWords module to @eggjs/ajv-keywords.
package.json Added the ajv package as a new dev dependency.

🐰✨
In the land of code, where the snippets roam,
A change was made, a new package to call home.
From ajv-keywords, we took a leap,
To @eggjs/ajv-keywords, a change not so steep.
Now with our update, so fresh and so clean,
We hop forward, on the scene!
🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

killagu
killagu reviewed Apr 7, 2024
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajv-formats 这个应该也要。

coderabbitai[bot]
coderabbitai bot reviewed Apr 7, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Actionable comments outside the diff hunks (1)
plugin/ajv/lib/Ajv.ts (1)

Line range hint 12-12: The usage of keyWords from @eggjs/ajv-keywords to add a 'transform' keyword is correctly implemented.

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b550d59 and ca7e74b.
Files selected for processing (2)
  • plugin/ajv/lib/Ajv.ts (1 hunks)
  • plugin/ajv/package.json (1 hunks)
Additional comments not posted (2)
plugin/ajv/lib/Ajv.ts (1)

3-3: The import statement update to use @eggjs/ajv-keywords is correctly implemented.

plugin/ajv/package.json (1)

53-53: The addition of @eggjs/ajv-keywords as a dependency with version ^5.1.0 is correctly implemented.

@fengmk2
Copy link
Member Author

fengmk2 commented Apr 7, 2024

ajv-formats 这个应该也要。

果然。。

@fengmk2 fengmk2 marked this pull request as draft April 7, 2024 06:26
coderabbitai[bot]
coderabbitai bot reviewed Apr 7, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ca7e74b and 21f44b5.
Files selected for processing (1)
  • package.json (1 hunks)

@fengmk2 fengmk2 changed the title fix: use @eggjs/ajv-keywords fix: use @eggjs/ajv-keywords and @eggjs/ajv-formats Apr 7, 2024
@fengmk2 fengmk2 marked this pull request as ready for review April 7, 2024 06:40
@fengmk2
Copy link
Member Author

fengmk2 commented Apr 7, 2024

@killagu done

killagu
killagu approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 31b02a0 into master Apr 7, 2024
11 checks passed
@fengmk2 fengmk2 deleted the use-ajv-keywords-fork branch April 7, 2024 07:04
@fengmk2
Copy link
Member Author

fengmk2 commented Apr 7, 2024

@killagu 发个版本

@killagu
Copy link
Contributor

killagu commented Apr 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fengmk2 @killagu