Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add types package #205

Merged
merged 8 commits into from
Apr 17, 2024
Merged

refactor: add types package #205

merged 8 commits into from
Apr 17, 2024

Conversation

gxkl
Copy link
Contributor

@gxkl gxkl commented Apr 7, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gxkl gxkl requested review from killagu and fengmk2 April 7, 2024 14:06
Copy link

coderabbitai bot commented Apr 7, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

224 files out of 300 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller-decorator 中的 HTTPResponse 定义需要挪到 types 里吗?

core/types/index.ts Outdated Show resolved Hide resolved
core/types/index.ts Outdated Show resolved Hide resolved
core/types/index.ts Outdated Show resolved Hide resolved
core/types/README.md Outdated Show resolved Hide resolved
core/types/package.json Outdated Show resolved Hide resolved
@gxkl gxkl force-pushed the refactor/types branch from 34446b7 to af9255c Compare April 9, 2024 09:24
@gxkl
Copy link
Contributor Author

gxkl commented Apr 9, 2024

controller-decorator 中的 HTTPResponse 定义需要挪到 types 里吗?

目前 types 里是纯 type 或者 interface。class 可能会包含逻辑,先不放了?

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2
Copy link
Member

fengmk2 commented Apr 10, 2024

@fengmk2
Copy link
Member

fengmk2 commented Apr 13, 2024

@gxkl 解决一下冲突合并发布?

Copy link

socket-security bot commented Apr 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eggjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +81 10.4 MB killagu
npm/[email protected] environment, filesystem, network, shell +28 1.13 MB fengmk2
npm/[email protected] None 0 5.34 kB fengmk2
npm/[email protected] None 0 1.28 kB jrk

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

@gxkl gxkl merged commit 334e13d into master Apr 17, 2024
11 checks passed
@gxkl gxkl deleted the refactor/types branch April 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants