Skip to content
This repository has been archived by the owner on Oct 3, 2022. It is now read-only.

Fixed #41 Race Condition in JCacheManager #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yogu
Copy link

@Yogu Yogu commented Mar 5, 2015

Using Futures to reserve cache names before configuring them to prevent
a different thread from creating it at the same time, possibly with
broken configuration

see #41

Using Futures to reserve cache names before configuring them to prevent
a different thread from creating it at the same time, possibly with
broken configuration
@terracotta-org
Copy link

Can one of the admins verify this patch?

@ljacomet
Copy link
Member

test this please

@Yogu
Copy link
Author

Yogu commented May 19, 2015

What's the status on this?

@alexsnaps
Copy link
Member

Hey @Yogu
Sorry it took so long to get back to you... I started reviewing your change and then... somehow forgot about all this! Ehcache3 is taking up pretty much all of our attentions...
Anyways, there are a bunch of issues with the changeset as it stands (race conditions, wrong interrupt handling, ... most importantly missing tests). But given how long it took me to get back to you, how would you rather go about this?

  • Should I comment on the PR?
  • Work a bit on that changeset on my own fork and discuss it further from there?
  • Some other option?

I understand this isn't probably fresh in your head at all anymore, so let me know how you'd best go about merging this in, and I'll act accordingly!
Again, sorry for having let this sit so long!
Alex

@Yogu
Copy link
Author

Yogu commented Aug 15, 2015

If you like to improve this pull request, feel free to do it, that would be great. I'm currently working on other projects, but would still be interested in getting this issue fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants