Fixes #3169 : Track event listeners keyed by type to allow earlier event firing veto #3170
Conversation
…lier event firing veto
chrisdennis
force-pushed
the
event-firing-veto
branch
from
2420642
to
162a5ea
Compare
|
Thank you for the fix. |
| @@ -86,8 +87,8 @@ public void onEvent(CacheEvent<? extends K, ? extends V> event) { | |||
| return listener; | |||
| } | |||
|
|
|||
| public boolean isForEventType(EventType type) { | |||
There was a problem hiding this comment.
Why this isForEventType check removed?
| @@ -40,12 +40,10 @@ | |||
| @Override | |||
| public void run() { | |||
| for(EventListenerWrapper<K, V> listenerWrapper : listenerWrappers) { | |||
| if (listenerWrapper.isForEventType(cacheEvent.getType())) { | |||
There was a problem hiding this comment.
Why this isForEventType check removed?
There was a problem hiding this comment.
listenerWrappers are already correctly preselected to only contain relevant entries from *syncListenersList.get(event.getType()) ?
@SamuelBussmann you're right... we should be able to pull this higher and eliminate a lot more work. Let me move this back to draft and until I get time to rework it. |
Just add a filter, whether any listener is interested in this event at all? That should keep most of the events from even getting created. |
Fixes ehcache#3169 : Track event listeners keyed by type to allow earlier event firing veto ehcache#3170
Fixes ehcache#3169 : Track event listeners keyed by type to allow earlier event firing veto ehcache#3170
No description provided.