Skip to content

Commit

Permalink
Add type="button" to option group collapse
Browse files Browse the repository at this point in the history
Fix #872

Cleanup readme a little
  • Loading branch information
Mike Harris committed Jul 15, 2021
1 parent edc57e0 commit 7efce37
Show file tree
Hide file tree
Showing 6 changed files with 61 additions and 39 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -246,4 +246,4 @@ DEPENDENCIES
github-pages

BUNDLED WITH
1.16.2
2.1.2
17 changes: 11 additions & 6 deletions README.MD
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,28 @@

MultiSelect progessively enhances an ordinary multiple select control into elegant drop down list of checkboxes, stylable with ThemeRoller.

### Demo Page
## Demo Page

Check out the demo page [here!](https://ehynds.github.io/jquery-ui-multiselect-widget/)

### Version 3
Version 3 of the widget is available in pre-release. This introduces a lot of new features and substantial performance imrovements.
## Version 3

Version 3 of the widget is available. This introduces a lot of new features and substantial performance imrovements.

Check out the [release notes](https://github.com/ehynds/jquery-ui-multiselect-widget/releases/tag/3.0.0) for an exact list of changes and see the [wiki](https://github.com/ehynds/jquery-ui-multiselect-widget/wiki/Migrating-to-Version-3) for the information you may need to switch over. The main wiki will be getting updates for the new features and changed options.

### Requirements
## Requirements

The [usage](https://github.com/ehynds/jquery-ui-multiselect-widget/wiki/Usage) section of the Wiki specifies the widget's dependencies.

# License
## License

MultiSelect is dual-licensed under the [GPL 2 license](https://github.com/ehynds/jquery-ui-multiselect-widget/blob/master/GPL-LICENSE) and the [MIT license](https://github.com/ehynds/jquery-ui-multiselect-widget/blob/master/MIT-LICENSE).

# Contributing
## Contributing

When submitting a pull request, please describe the change you are making - preferably with a use case. Unit tests are now (14 March 2016) required for the pull to be merged.

Please do not submit minified code in your pull request, that tends to cause merge conflicts.

You can test the demo pages locally by navigating to the `docs` directory and running `bundle install && bundle exec jekyll server`.
2 changes: 1 addition & 1 deletion docs/js/widget.min.js

Large diffs are not rendered by default.

73 changes: 45 additions & 28 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jquery-ui-multiselect-widget",
"description": "MultiSelect progessively enhances an ordinary multiple select control into elegant drop down list of checkboxes, stylable with ThemeRoller.",
"version": "3.0.0",
"version": "3.0.1",
"license": "MIT or GPL-2.0",
"author": "Eric Hynds",
"contributors": [
Expand Down
4 changes: 2 additions & 2 deletions src/jquery.multiselect.js
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@
}

if (this.options.header.constructor == Object) {
var options = Object.keys(this.options.header)
var options = Object.keys(this.options.header);
for (var x = 0; x < options.length; x++) {
var displayText = options[x];
var linkInfoKey = this.options.header[displayText];
Expand Down Expand Up @@ -532,7 +532,7 @@
// Build the list section for this optgroup, complete w/ option inputs...
var $collapseButton = !!self.options.groupsCollapsable
? $( document.createElement('button') )
.attr({'title': self.linkInfo.collapse.title})
.attr({'title': self.linkInfo.collapse.title, 'type': 'button'})
.addClass('ui-state-default ui-corner-all ui-multiselect-collapser')
.html(self.linkInfo.collapse.icon)
: null;
Expand Down

0 comments on commit 7efce37

Please sign in to comment.