Skip to content

German translation - by @Marc-R2#137

Merged
eibex merged 2 commits intoeibex:masterfrom
Marc-R2:german_translate
Sep 30, 2024
Merged

German translation - by @Marc-R2#137
eibex merged 2 commits intoeibex:masterfrom
Marc-R2:german_translate

Conversation

@Marc-R2
Copy link
Copy Markdown
Contributor

@Marc-R2 Marc-R2 commented Sep 29, 2024

Add german translation de-de.json

@eibex
Copy link
Copy Markdown
Owner

eibex commented Sep 29, 2024

Hi! Thanks for the PR.
There are a few errors that must be fixed before we can merge it. Discord has a character limit for both messages and modals (modals/cmd descriptions are particularly strict since they max out at 100 characters).
The following strings need to be fixed:
brief-settings-notify: must be 100 or less characters (now it's 148)
brief-settings-systemchannel: must be 100 or less characters (now it's 106)
message-reaction-option-channel: must be 100 or less characters (now it's 105)
message-reaction-option-action: must be 100 or less characters (now it's 105)
settings-systemchannel-option-type: must be 100 or less characters (now it's 112)
settings-activity-option-action: must be 100 or less characters (now it's 104)
settings-activity-option-activity: must be 100 or less characters (now it's 105)

fix(msg too long):
for
- brief-settings-notify: must be 100 or less characters (was 148)
- brief-settings-systemchannel: must be 100 or less characters (was 106)
- message-reaction-option-channel: must be 100 or less characters (was 105)
- message-reaction-option-action: must be 100 or less characters (was 105)
- settings-systemchannel-option-type: must be 100 or less characters (was 112)
- settings-activity-option-action: must be 100 or less characters (was 104)
- settings-activity-option-activity: must be 100 or less characters (was 105)
@Marc-R2
Copy link
Copy Markdown
Contributor Author

Marc-R2 commented Sep 30, 2024

Oh, I didn't know that. I have corrected the mentioned lines.

@eibex
Copy link
Copy Markdown
Owner

eibex commented Sep 30, 2024

Thanks!

@eibex eibex merged commit 289306f into eibex:master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants