fix(dRICH): CentralCKFTrajectories -> CentralCKFActsTrajectories

[c-dilks]

Briefly, what does this PR introduce?

Fix dRICH track propagation by using CentralCKFActsTrajectories instead of CentralCKFTrajectories

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Documentation update
• Other: __

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes, should restore functionality to dRICH

[wdconinc]

As long as there is nothing in the default output files that relies on the DRICH code, we are going to keep breaking the DRICH unintentionally because it is not tested for... So, you could (have) avoid(ed) this by adding DRICHAerogelTracks and DRICHGasTracks to the JEventProcessorPODIO.cc list, probably even as part of this PR.

[c-dilks]

As long as there is nothing in the default output files that relies on the DRICH code, we are going to keep breaking the DRICH unintentionally because it is not tested for... So, you could (have) avoid(ed) this by adding DRICHAerogelTracks and DRICHGasTracks to the JEventProcessorPODIO.cc list, probably even as part of this PR.

• tried before: feat(DRICH)!: enable raw hits and projected tracks by default #655
• or feat!: enable dRICH PID in production #734 which awaits feat!: link dRICH PID with Reconstructed*ChargedParticles #829

[wdconinc]

#829 is on my list to review and merge this week...

[c-dilks]

https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/293 is also ready (I just realized I never marked it "ready"), but is only useful if someone routinely checks the plots. This particular track propagation issue just showed up as empty plots.

[wdconinc]

only useful if someone routinely checks the plots

We have several benchmarks that fail if there are no entries when there are entries expected.

[c-dilks]

only useful if someone routinely checks the plots

We have several benchmarks that fail if there are no entries when there are entries expected.

We should add this feature, this MR is just a starting point. I keep trying to push @chchatte92 to improve the benchmarks, since he now does quite a lot more by hand :)

[chchatte92]

only useful if someone routinely checks the plots

We have several benchmarks that fail if there are no entries when there are entries expected.

We should add this feature, this MR is just a starting point. I keep trying to push @chchatte92 to improve the benchmarks, since he now does quite a lot more by hand :)

Absolutely. Let's say, I will add at least these three-four features by next week to the benchmarks

• Gaussian Fits for all the Residuals and theta distributions.
• Apart from SPE Cherenkov angle as a function of phi, also SPE resolution.
• Poisson Fit to the NPE distribution

Does it sound ok?

[c-dilks]

Testing this fix with benchmarks using eic/drich-dev#98 since it seems I never added them to the CI config.

And adding benchmarks to the CI config with https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/306

[c-dilks]

eic/drich-dev#103 blocks me from testing eta and momentum scans, but at least for single fixed momenta, dRICH PID appears to be recovered after this PR.

[wdconinc]

Yup.