Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gapless beam pipe vacuum #831

Merged
merged 6 commits into from
Mar 5, 2025
Merged

Gapless beam pipe vacuum #831

merged 6 commits into from
Mar 5, 2025

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Feb 21, 2025

Briefly, what does this PR introduce?

Changes the beampipe chain so it no longer adds a small air gap when there is a bend in the pipe and instead joins them together properly with a torus segment.

Exaggerated geometry pictures showing the difference between current and new implementation.
Pipe_Chain_Old
Pipe_Chain_New

The previous implementation was sufficient to remove the overlaps when the bend has a very small angle and small radius, but a small air gap in the vacuum isn't ideal even then.

Motivation for introducing this is that to update the backwards beamline magnets to match the current lattice a bend needs to be added. Currently I believe these bends in the beampipe chain are only present in material we don't care about tracking particles through.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Should remove small amounts of air from bending beamline chains with bends.

@simonge simonge requested a review from rahmans1 February 24, 2025 12:28
@veprbl veprbl enabled auto-merge (squash) March 4, 2025 18:40
@veprbl veprbl disabled auto-merge March 4, 2025 18:41
@veprbl veprbl changed the title Improve beam pipe chain Gapless beam pipe vacuum Mar 4, 2025
@veprbl veprbl enabled auto-merge (squash) March 4, 2025 18:41
@veprbl veprbl merged commit 6a027c1 into main Mar 5, 2025
88 checks passed
@veprbl veprbl deleted the Join-Pipe-Chain-Better branch March 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants