Skip to content

Fix frozen TaskFailedEvent mutation in workforce failure handling #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuoPengcheng12138 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix frozen TaskFailedEvent mutation in workforce failure handling #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions backend/app/utils/workforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,11 +692,10 @@ async def _handle_failed_task(self, task: Task) -> bool:
event = TaskFailedEvent(
task_id=task.id,
error_message=error_msg,
worker_id=(task.assigned_worker_id
if hasattr(task, "assigned_worker_id") else None),
metadata={"failure_count": task.failure_count},
)
# Add failure details if available
if hasattr(task, 'assigned_worker_id'):
event.worker_id = task.assigned_worker_id
event.failure_count = task.failure_count
metrics_callbacks[0].log_task_failed(event)

return result
Expand Down