Skip to content

Fix configured model not taking effect for newly created providers #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −12
Draft

Fix configured model not taking effect for newly created providers #1184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b80d9
Initial plan
Copilot Feb 8, 2026
a6ed86e
Fix configured model not taking effect for newly created providers
Copilot Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions src/pages/Setting/Models.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,13 @@ export default function SettingModels() {
// add: refresh provider list after saving, update form and switch editable status
const res = await proxyFetchGet('/api/providers');
const providerList = Array.isArray(res) ? res : res.items || [];

// Find the saved provider's id from the freshly fetched list
// to avoid using stale form state in handleSwitch
const savedProvider = providerList.find(
(p: any) => p.provider_name === item.id
);

setForm((f) =>
f.map((fi, i) => {
const item = items[i];
Expand Down Expand Up @@ -550,16 +557,17 @@ export default function SettingModels() {
})
);

// Check if this was a pending default model selection
if (
pendingDefaultModel &&
pendingDefaultModel.category === 'custom' &&
pendingDefaultModel.modelId === item.id
) {
await handleSwitch(idx, true);
setPendingDefaultModel(null);
} else {
handleSwitch(idx, true);
// Set this provider as preferred using the freshly fetched
// provider_id, since form state may not have been updated yet
if (savedProvider?.id) {
await handleSwitch(idx, true, savedProvider.id);
if (
pendingDefaultModel &&
pendingDefaultModel.category === 'custom' &&
pendingDefaultModel.modelId === item.id
) {
setPendingDefaultModel(null);
}
}
} finally {
setLoading(null);
Expand Down Expand Up @@ -734,7 +742,11 @@ export default function SettingModels() {
}
}, [localEnabled]);

const handleSwitch = async (idx: number, checked: boolean) => {
const handleSwitch = async (
idx: number,
checked: boolean,
providerId?: number
) => {
if (!checked) {
setActiveModelIdx(null);
setLocalEnabled(true);
Expand All @@ -752,7 +764,7 @@ export default function SettingModels() {
}
try {
await proxyFetchPost('/api/provider/prefer', {
provider_id: form[idx].provider_id,
provider_id: providerId ?? form[idx].provider_id,
});
setModelType('custom');
setActiveModelIdx(idx);
Expand Down