Skip to content

fix(history): prevent settings content from overlapping tab bar on sc… #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4pmtong merged 3 commits into from
Feb 10, 2026
Merged

fix(history): prevent settings content from overlapping tab bar on sc… #1186

4pmtong merged 3 commits into from
Feb 10, 2026
+2 −1

Conversation

@claytonlin1110
Copy link
Contributor

@claytonlin1110 claytonlin1110 commented Feb 8, 2026 •
edited
Loading

Summary

  • Sticky tab bar no longer shows a visible top line when scrolling (use -top-px to avoid subpixel gap; remove bottom border).

Testing

  • Scroll on Settings (and other tabs): no overlap, no top line under the tab bar.

Before

before.mp4

After

after.mp4

@claytonlin1110 claytonlin1110 marked this pull request as draft February 8, 2026 12:27
@claytonlin1110 claytonlin1110 force-pushed the fix/settings-page-tab-bar-overlap branch from 61452f2 to 997cb1d Compare February 8, 2026 12:39
@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 8, 2026

@Wendong-Fan Would you please re-open this PR?

@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 8, 2026

Sorry not sure what's happening. But this is my local branch, but it's not updated in here. is it because this Pr is closed?
https://github.com/claytonlin1110/eigent/tree/fix/settings-page-tab-bar-overlap

@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 8, 2026

@bittoby ^^
Sorry for pinging you as this will be my first contribution on this repo, i don't know who is the owner. Please re-open this PR.

@Wendong-Fan
Copy link
Contributor

Wendong-Fan commented Feb 8, 2026

thanks @claytonlin1110 for the contribution! just reopened the pr

@Wendong-Fan Wendong-Fan reopened this Feb 8, 2026
@Wendong-Fan Wendong-Fan added this to the Sprint 14 milestone Feb 8, 2026
@claytonlin1110 claytonlin1110 marked this pull request as ready for review February 8, 2026 18:42
@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 8, 2026

Thank you, @Wendong-Fan
@4pmtong @a7m-1st Please review this PR as it's ready now.

4pmtong
4pmtong approved these changes Feb 9, 2026
View reviewed changes
Copy link
Collaborator

@4pmtong 4pmtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @claytonlin1110 for contribution!

@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 9, 2026

Does this repo require 2 Reviewers' approval to get it merged?

@claytonlin1110
Copy link
Contributor Author

claytonlin1110 commented Feb 9, 2026

@4pmtong are you able to merge this?

@4pmtong 4pmtong merged commit 12a09f5 into eigent-ai:main Feb 10, 2026
7 checks passed
@4pmtong
Copy link
Collaborator

4pmtong commented Feb 10, 2026

Thanks @claytonlin1110! merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4pmtong 4pmtong 4pmtong approved these changes

@a7m-1st a7m-1st Awaiting requested review from a7m-1st

Assignees

@claytonlin1110 claytonlin1110

Labels

None yet

Projects

None yet

Milestone

Sprint 14

Development

Successfully merging this pull request may close these issues.

3 participants

@claytonlin1110 @Wendong-Fan @4pmtong