chore: remove unused mcpLocal code in chatStore#1194
chore: remove unused mcpLocal code in chatStore#1194Wendong-Fan merged 5 commits intoeigent-ai:mainfrom
Conversation
|
@Wendong-Fan @Pakchoioioi Please review this PR. |
|
@Wendong-Fan could you merge this pr? |
Wendong-Fan
left a comment
There was a problem hiding this comment.
thanks @bittoby for the fix! LGTM
|
Hi @bittoby, after investigating, I found that MCP functionality actually works correctly through the AddWorker path when users add an agent via AddWorker and select MCP tools, the As @fengju0213 mentioned in the #959 (comment), the original issue might be a user configuration problem rather than a code bug, a cleaner approach might be to remove the unused mcpLocal code instead since it's loaded but never used, this would improve code quality without changing the intended behavior, i will update directly in your PR, WDYT? |
Closes: #959
Description
Fixes models not seeing or using installed MCPs (e.g. Firecrawl). The frontend was loading local MCP config from Electron but always sending an empty
installed_mcpin the chat request, so the backend never received the real MCP list. The request body now sends the actual local MCP config when starting a chat so the backend can connect to MCP servers and expose their tools to the model.What is the purpose of this pull request?