Skip to content

fix(electron): skip single-instance lock in dev to prevent dev server… #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dataCenter430 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(electron): skip single-instance lock in dev to prevent dev server… #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion electron/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,9 @@ if (os.release().startsWith('6.1')) app.disableHardwareAcceleration();
// Set application name for Windows 10+ notifications
if (process.platform === 'win32') app.setAppUserModelId(app.getName());

if (!app.requestSingleInstanceLock()) {
// Only enforce single-instance in production. In dev, a second instance (e.g. second
// npm run dev) would quit here and take its dev server down; skip so multiple dev instances work.
if (!VITE_DEV_SERVER_URL && !app.requestSingleInstanceLock()) {
app.quit();
process.exit(0);
}
Expand Down Expand Up @@ -303,6 +305,10 @@ function processQueuedProtocolUrls() {

// ==================== single instance lock ====================
const setupSingleInstanceLock = () => {
if (VITE_DEV_SERVER_URL) {
// Dev: allow multiple instances so a second npm run dev doesn't quit and kill its dev server
return;
}
const gotLock = app.requestSingleInstanceLock();
if (!gotLock) {
log.info('no-lock');
Expand Down