fix(backend): restrict CORS to configurable origins and explicit methods/headers#1283
Open
dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
Open
fix(backend): restrict CORS to configurable origins and explicit methods/headers#1283dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
dataCenter430 wants to merge 1 commit intoeigent-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
CORS configuration: missing or overly permissive CORS can allow unwanted origins.
Closes #1260
Description
Replace permissive CORS (allow_origins=[""] with allow_credentials=True and
allow_methods/allow_headers=[""]) with a safe, configurable setup:
In development, if unset, allow only http://localhost:5173, 127.0.0.1:5173,
and ports 3000. In non-development, allow no origins until CORS_ORIGINS is set.
Document CORS_ORIGINS in backend README. Ensures credentials work correctly
(no wildcard origin with credentials) and reduces risk of unwanted origins
calling the API from the browser.
Why?
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement