fix: reconcile historical follow-up input mirrors - #2000
Merged
Merged
Conversation
4pmtong
force-pushed
the
feat/deduplicate-failed-followup-messages
branch
2 times, most recently
from
October 2, 2026 07:55
4cab7e5 to
7417651
Compare
4pmtong
marked this pull request as ready for review
October 2, 2026 14:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Description
Cloud history can replay a legacy
confirmedstep before canonical Run hydration supplies the same admitteduser.message. That sequence rendered the user's failed follow-up twice in the transcript.Historical Cloud playback normalizes
confirmedframes tolegacy.stepwithlegacyStep: confirmed, while the local journal writeslegacy.confirmed. Presentation previously recognized only the latter. Now a canonicaluser.messageowns every confirmed mirror of its Run, in either form, keyed by Project and Run. This follows design 19 §7:legacy.confirmedis only a read-only fallback for Runs with no canonical input. Ownership is per Run and does not compare content or message identity, so a resume instruction echoed into a resumed Run asconfirmedstays hidden. Legacy-only history, other Runs, other Projects,human_reply, and optimistic queries are unaffected. Raw events and persistence remain unchanged; the rule is confined to transcript presentation.The original live v1.0.4 queued-to-403 report is still under investigation. This PR fixes the independently reproduced Cloud-history playback plus canonical-hydration duplicate.
Testing Evidence (REQUIRED)
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement