Merge pull request #258 from ej2/0.9.1

0.9.1

CHANGELOG.rst

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+* 0.9.1 (July ??, 2021)
+    * Added response status code when raising unauthorized exceptions
+    * Added pending deprecation warnings to enable_global and disable_global
+
 * 0.9.0 (July 20, 2021)
     * Added missing TxnDate to Invoice
     * Updated requirements

Pipfile

@@ -14,7 +14,6 @@ requests = ">=2.26.0"
 simplejson = ">=3.17.0"
 six = ">=1.14.0"
 nose = "*"
-authclient = "*"
 coverage = "*"
 twine = "*"
 

README.md

@@ -241,11 +241,11 @@ Void an invoice:
     invoice.Id = 7
     invoice.void(qb=client)
 
-If your consumer_key never changes you can enable the client to stay running:
+If your company_id never changes you can enable the client to stay running (deprecation warning: will be removed in next release):
 
     QuickBooks.enable_global()
 
-You can disable the global client like so:
+You can disable the global client like so (deprecation warning: will be removed in next release):
 
     QuickBooks.disable_global()
 

quickbooks/client.py

@@ -1,3 +1,5 @@
+import warnings
+
 try:  # Python 3
     import http.client as httplib
     from urllib.parse import parse_qsl
@@ -114,6 +116,7 @@ def disable_global(cls):
         """
         Disable use of singleton pattern.
         """
+        warnings.warn("disable_global deprecated", PendingDeprecationWarning)
         QuickBooks.__use_global = False
         QuickBooks.__instance = None
 
@@ -122,6 +125,7 @@ def enable_global(cls):
         """
         Allow use of singleton pattern.
         """
+        warnings.warn("enable_global deprecated", PendingDeprecationWarning)
         QuickBooks.__use_global = True
 
     def _drop(self):
@@ -230,7 +234,8 @@ def make_request(self, request_type, url, request_body=None, content_type='appli
         req = self.process_request(request_type, url, headers=headers, params=params, data=request_body)
 
         if req.status_code == httplib.UNAUTHORIZED:
-            raise exceptions.AuthorizationException("Application authentication failed", detail=req.text)
+            raise exceptions.AuthorizationException(
+                "Application authentication failed", error_code=req.status_code, detail=req.text)
 
         try:
             result = req.json()
@@ -363,7 +368,8 @@ def download_pdf(self, qbbo, item_id):
 
             if response.status_code == httplib.UNAUTHORIZED:
                 # Note that auth errors have different result structure which can't be parsed by handle_exceptions()
-                raise exceptions.AuthorizationException("Application authentication failed", detail=response.text)
+                raise exceptions.AuthorizationException(
+                    "Application authentication failed", error_code=response.status_code, detail=response.text)
 
             try:
                 result = response.json()

setup.py

@@ -10,7 +10,7 @@ def read(*parts):
         return fp.read()
 
 
-VERSION = (0, 9, 0)
+VERSION = (0, 9, 1)
 version = '.'.join(map(str, VERSION))
 
 setup(
@@ -33,7 +33,6 @@ def read(*parts):
         'setuptools',
         'intuit-oauth==1.2.4',
         'rauth>=0.7.3',
-        'authclient',
         'requests>=2.26.0',
         'simplejson>=3.17.0',
         'six>=1.14.0',

tests/integration/test_invoice.py

@@ -7,7 +7,6 @@
 import uuid
 
 class InvoiceTest(QuickbooksTestCase):
-
     def create_invoice(self, customer, request_id=None):
         invoice = Invoice()
 
@@ -27,6 +26,24 @@ def create_invoice(self, customer, request_id=None):
         invoice.CustomerMemo.value = "Customer Memo"
         invoice.save(qb=self.qb_client, request_id=request_id)
         return invoice
+
+    def test_query_by_customer_ref(self):
+        customer = Customer.all(max_results=1, qb=self.qb_client)[0]
+        invoice = Invoice.query(
+            "select * from Invoice where CustomerRef = '{0}'".format(customer.Id), qb=self.qb_client)
+
+        print(invoice[0].Line[0].LineNum)
+        print(invoice[0].Line[0].Amount)
+        self.assertEquals(invoice[0].CustomerRef.name, customer.DisplayName)
+
+    def test_where(self):
+        customer = Customer.all(max_results=1, qb=self.qb_client)[0]
+
+        invoice = Invoice.where(
+            "CustomerRef = '{0}'".format(customer.Id), qb=self.qb_client)
+
+        print(invoice[0])
+        self.assertEquals(invoice[0].CustomerRef.name, customer.DisplayName)
 
     def test_create(self):
         customer = Customer.all(max_results=1, qb=self.qb_client)[0]