Skip to content

Commit

Permalink
Merge pull request #334 from uncategorizedexpense/master
Browse files Browse the repository at this point in the history
Minor but critical tweaks to default options for DetailLine + Vendor objects
  • Loading branch information
ej2 authored Jan 3, 2024
2 parents 7d34f25 + 209ab02 commit cbb974d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions quickbooks/objects/detailline.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ class AccountBasedExpenseLineDetail(QuickbooksBaseObject):
def __init__(self):
super(AccountBasedExpenseLineDetail, self).__init__()
self.BillableStatus = None
self.TaxAmount = 0
self.TaxInclusiveAmt = 0

self.CustomerRef = None
Expand Down Expand Up @@ -234,8 +233,8 @@ def __init__(self):
super(ItemBasedExpenseLineDetail, self).__init__()
self.BillableStatus = None
self.UnitPrice = 0
self.TaxInclusiveAmt = 0
self.Qty = 0
self.TaxInclusiveAmt = 0
self.ItemRef = None
self.ClassRef = None
self.PriceLevelRef = None
Expand Down
2 changes: 1 addition & 1 deletion quickbooks/objects/vendor.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def __init__(self):
self.Balance = 0
self.BillRate = 0
self.AcctNum = ""
self.Vendor1099 = True
self.Vendor1099 = False
self.TaxReportingBasis = ""

self.BillAddr = None
Expand Down
1 change: 0 additions & 1 deletion tests/unit/objects/test_detailline.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def test_init(self):

self.assertEqual(detail.BillableStatus, None)
self.assertEqual(detail.UnitPrice, 0)
self.assertEqual(detail.TaxInclusiveAmt, 0)
self.assertEqual(detail.Qty, 0)
self.assertEqual(detail.ItemRef, None)
self.assertEqual(detail.ClassRef, None)
Expand Down

0 comments on commit cbb974d

Please sign in to comment.