Use with to open file attachments #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redblacktree
commented
Mar 11, 2024
There was a problem hiding this comment.
I also moved the open() call closer to where it's used
ej2
approved these changes
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 93.45% 93.72% +0.27%
==========================================
Files 103 103
Lines 3924 3935 +11
Branches 171 174 +3
==========================================
+ Hits 3667 3688 +21
+ Misses 217 209 -8
+ Partials 40 38 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the file is closed even if there are errors in the process. I discovered this issue because I got a non-200 response that caused the client to raise error code 10000, and my subsequent cleanup code failed to delete a temp file because it was already open.