Move MSRV to cargo.toml and remove build.rs #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks MSRV detection logic, using the `rust-version` field in Cargo manifest. It allows dropping `build.rs` and removing the `version_check` build-dependency. Ref: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field
|
/cc @ejmahler for review. |
|
The solution with build.rs was created to allow different msrv for different features and architectures. This isn't needed right now, but will be again once this get completed for example: #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks MSRV detection logic, using the
rust-versionfield in Cargo manifest. It allows droppingbuild.rsand removing theversion_checkbuild-dependency.Ref: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field