Skip to content

Optionally use certifi certificates #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optionally use certifi certificates #388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7593549
Use certifi certificates if available
mvdbeek Jul 11, 2025
a5dc956
Add a flag to use certifi certificates
mvdbeek Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions nodeenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
is_CYGWIN = platform.system().startswith(('CYGWIN', 'MSYS'))

ignore_ssl_certs = False
use_certifi = False

# ---------------------------------------------------------
# Utils
Expand Down Expand Up @@ -368,6 +369,11 @@ def make_parser():
action='store_true', default=Config.ignore_ssl_certs,
help='Ignore certificates for package downloads. - UNSAFE -')

parser.add_argument(
'--with-certifi', dest='with_certifi',
action='store_true', default=False,
help='Use certifi certificate bundle if available')

parser.add_argument(
metavar='DEST_DIR', dest='env_dir', nargs='?',
help='Destination directory')
Expand Down Expand Up @@ -649,6 +655,18 @@ def urlopen(url):
context = ssl.SSLContext(ssl.PROTOCOL_TLS)
context.verify_mode = ssl.CERT_NONE
return urllib2.urlopen(req, context=context)

# Use certifi certificates if available and requested
if use_certifi:
try:
import certifi
context = ssl.create_default_context(cafile=certifi.where())
return urllib2.urlopen(req, context=context)
except ImportError:
# Fall back to default behavior if certifi is not available
pass

# Default behavior without certifi
return urllib2.urlopen(req)

# ---------------------------------------------------------
Expand Down Expand Up @@ -1118,8 +1136,10 @@ def main():

global src_base_url
global ignore_ssl_certs
global use_certifi

ignore_ssl_certs = args.ignore_ssl_certs
use_certifi = args.with_certifi

src_domain = None
if args.mirror:
Expand Down