Skip to content

Use sh instead of bash #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use sh instead of bash #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ There are several alternatives that create isolated environments:
Nave stores all environments in one directory ``~/.nave``. Can create
per node version environments using `nave use envname versionname`.
Can not pass additional arguments into configure (for example --without-ssl)
Can't run on windows because it relies on bash.
Can't run on windows because it relies on a POSIX shell.

* `nvm <https://github.com/creationix/nvm/blob/master/nvm.sh>`_ - Node Version
Manager. It is necessarily to do `nvm sync` for caching available node.js
Expand Down
6 changes: 3 additions & 3 deletions nodeenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ def install_npm(env_dir, _src_dir, args):
)
proc = subprocess.Popen(
(
'bash', '-c',
'sh', '-c',
'. {0} && npm install -g npm@{1}'.format(
_quote(join(env_dir, 'bin', 'activate')),
args.npm,
Expand Down Expand Up @@ -1177,7 +1177,7 @@ def main():
""",
}

SHIM = """#!/usr/bin/env bash
SHIM = """#!/usr/bin/env sh
export NODE_PATH='__NODE_VIRTUAL_ENV__/lib/node_modules'
export NPM_CONFIG_PREFIX='__NODE_VIRTUAL_ENV__'
export npm_config_prefix='__NODE_VIRTUAL_ENV__'
Expand Down Expand Up @@ -1279,7 +1279,7 @@ def main():

ACTIVATE_SH = r"""

# This file must be used with "source bin/activate" *from bash*
# This file must be used with "source bin/activate" *from sh*
# you cannot run it directly

deactivate_node () {
Expand Down