test: fix broken tests

ekristen · Oct 26, 2024 · 16c03bc · 16c03bc
1 parent b93c743
commit 16c03bc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/pkg/asset/asset_test.go b/pkg/asset/asset_test.go
@@ -491,8 +491,8 @@ func TestAssetInstall(t *testing.T) {
 			assert.NoError(t, err)
 
 			for _, fileName := range c.expectedFiles {
-				destBinaryName := fmt.Sprintf("test-id-%s", filepath.Base(fileName))
-				destBinPath := filepath.Join(binDir, destBinaryName)
+				destBinaryName := filepath.Base(fileName)
+				destBinPath := filepath.Join(optDir, destBinaryName)
 
 				baseLinkName := filepath.Join(binDir, filepath.Base(fileName))
 				versionedLinkName := filepath.Join(binDir, fmt.Sprintf("%s@%s", filepath.Base(fileName), "1.0.0"))

diff --git a/pkg/osconfig/osconfig_test.go b/pkg/osconfig/osconfig_test.go
@@ -137,7 +137,7 @@ func TestOS_InvalidOS(t *testing.T) {
 		{
 			name:     "Windows",
 			os:       osconfig.New(osconfig.Windows, osconfig.AMD64),
-			expected: []string{osconfig.Linux, osconfig.Darwin},
+			expected: []string{osconfig.Linux, osconfig.Darwin, osconfig.FreeBSD},
 		},
 		{
 			name:     "Linux",
@@ -147,7 +147,7 @@ func TestOS_InvalidOS(t *testing.T) {
 		{
 			name:     "Darwin",
 			os:       osconfig.New(osconfig.Darwin, osconfig.AMD64),
-			expected: []string{osconfig.Windows, osconfig.Linux},
+			expected: []string{osconfig.Windows, osconfig.Linux, osconfig.FreeBSD},
 		},
 	}
 

diff --git a/pkg/score/score_test.go b/pkg/score/score_test.go
@@ -211,7 +211,7 @@ func TestScore(t *testing.T) {
 	for _, c := range cases {
 		t.Run(c.name, func(t *testing.T) {
 			actual := Score(c.names, c.opts)
-			assert.Equal(t, c.expected, actual)
+			assert.ElementsMatch(t, c.expected, actual)
 		})
 	}
 }
diff --git a/pkg/source/github.go b/pkg/source/github.go
@@ -97,6 +97,8 @@ func (s *GitHub) FindRelease(ctx context.Context) error {
 	var err error
 	var release *github.RepositoryRelease
 
+	logrus.WithField("owner", s.GetOwner()).WithField("repo", s.GetRepo()).Trace("finding release")
+
 	if s.Version == provider.VersionLatest {
 		release, _, err = s.client.Repositories.GetLatestRelease(ctx, s.GetOwner(), s.GetRepo())
 		if err != nil && !strings.Contains(err.Error(), "404 Not Found") {
@@ -139,7 +141,7 @@ func (s *GitHub) FindRelease(ctx context.Context) error {
 		return fmt.Errorf("release not found")
 	}
 
-	log.Infof("installing version: %s", strings.TrimPrefix(release.GetTagName(), "v"))
+	log.Infof("selected version: %s", strings.TrimPrefix(release.GetTagName(), "v"))
 
 	s.Release = release