refactor: code cleanup

.goreleaser.yml

@@ -1,4 +1,3 @@
-version: 2
 release:
   github:
     owner: ekristen
@@ -52,12 +51,13 @@ signs:
     cmd: cosign
     signature: "${artifact}.sig"
     certificate: "${artifact}.pem"
-    args: ["sign-blob", "--yes", "--oidc-provider=github", "--oidc-issuer=https://token.actions.githubusercontent.com", "--output-certificate=${certificate}", "--output-signature=${signature}", "${artifact}"]
+    args:
+      ["sign-blob", "--yes", "--oidc-provider=github", "--oidc-issuer=https://token.actions.githubusercontent.com", "--output-certificate=${certificate}", "--output-signature=${signature}", "${artifact}"]
     artifacts: all
 checksum:
   name_template: "checksums.txt"
 snapshot:
   name_template: '{{ trimprefix .Summary "v" }}'
 # We are skipping changelog because we are using semantic release
 changelog:
-  disable: true
+  skip: true

pkg/asset/asset.go

@@ -47,26 +47,6 @@ const (
 	SBOM
 )
 
-func ScoreAll(assets []IAsset, opts *ScoreOptions) {
-	for _, asset := range assets {
-		asset.Score(opts)
-	}
-}
-
-func Best(assets []IAsset, aType Type) *Asset {
-	var best *Asset
-
-	for _, asset := range assets {
-		if best == nil || asset.GetScore() > best.score && asset.GetType() == aType {
-			best = asset.GetAsset()
-		}
-	}
-
-	return best
-}
-
-// ----------------------------------------------------------------------------
-
 type IAsset interface {
 	GetName() string
 	GetDisplayName() string
@@ -112,6 +92,7 @@ type Asset struct {
 	Arch    string
 	Version string
 
+	Extension    string
 	DownloadPath string
 	Hash         string
 	TempDir      string
@@ -200,8 +181,8 @@ func (a *Asset) Score(opts *ScoreOptions) int {
 	var scoringKeys []string
 	var scoringValues = make(map[string]int)
 
-	for _, os := range opts.OS {
-		scoringValues[strings.ToLower(os)] = 10
+	for _, os1 := range opts.OS {
+		scoringValues[strings.ToLower(os1)] = 10
 	}
 	for _, arch := range opts.Arch {
 		scoringValues[strings.ToLower(arch)] = 5

pkg/source/github_asset.go

@@ -47,6 +47,7 @@ func (a *GitHubAsset) Download(ctx context.Context) error {
 
 	assetFile := filepath.Join(downloadsDir, filename)
 	a.DownloadPath = assetFile
+	a.Extension = filepath.Ext(a.DownloadPath)
 
 	assetFileHash := assetFile + ".sha256"
 

pkg/source/gitlab_asset.go

@@ -36,6 +36,7 @@ func (a *GitLabAsset) Download(ctx context.Context) error {
 
 	assetFile := filepath.Join(downloadsDir, filename)
 	a.DownloadPath = assetFile
+	a.Extension = filepath.Ext(a.DownloadPath)
 
 	assetFileHash := assetFile + ".sha256"
 	stats, err := os.Stat(assetFileHash)

pkg/source/hashicorp_asset.go

@@ -39,6 +39,7 @@ func (a *HashicorpAsset) Download(ctx context.Context) error {
 
 	assetFile := filepath.Join(downloadsDir, filename)
 	a.DownloadPath = assetFile
+	a.Extension = filepath.Ext(a.DownloadPath)
 
 	assetFileHash := assetFile + ".sha256"
 	stats, err := os.Stat(assetFileHash)

pkg/source/homebrew_asset.go

@@ -75,6 +75,7 @@ func (a *HomebrewAsset) Download(ctx context.Context) error {
 
 	assetFile := filepath.Join(downloadsDir, filename)
 	a.DownloadPath = assetFile
+	a.Extension = filepath.Ext(a.DownloadPath)
 
 	assetFileHash := assetFile + ".sha256"
 	stats, err := os.Stat(assetFileHash)