Skip to content

Commit

Permalink
Merge pull request #7563 from eksctl-io/revert-fix-presigned
Browse files Browse the repository at this point in the history
Revert removing RetryMetricsHeader in presigned requests
  • Loading branch information
yuxiang-zhang committed Feb 16, 2024
2 parents 123b48d + b4d74c2 commit d05aee2
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions pkg/eks/auth/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import (
"fmt"
"time"

"github.com/aws/aws-sdk-go-v2/aws/retry"
"github.com/aws/aws-sdk-go-v2/service/sts"

"github.com/aws/smithy-go/middleware"
smithyhttp "github.com/aws/smithy-go/transport/http"

api "github.com/weaveworks/eksctl/pkg/apis/eksctl.io/v1alpha5"
Expand Down Expand Up @@ -71,11 +69,6 @@ func (g Generator) appendPresignHeaderValuesFunc(clusterID string) func(stsOptio
// Add clusterId Header.
smithyhttp.SetHeaderValue(clusterIDHeader, clusterID),
// Add X-Amz-Expires query param.
smithyhttp.SetHeaderValue("X-Amz-Expires", "60"),
// Remove any extraneous headers: https://github.com/eksctl-io/eksctl/issues/7486.
func(stack *middleware.Stack) error {
_, err := stack.Finalize.Remove((&retry.MetricsHeader{}).ID())
return err
})
smithyhttp.SetHeaderValue("X-Amz-Expires", "60"))
}
}

0 comments on commit d05aee2

Please sign in to comment.