Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRUD and Managed integration tests #6622

Merged
merged 6 commits into from
May 19, 2023
Merged

Fix CRUD and Managed integration tests #6622

merged 6 commits into from
May 19, 2023

Conversation

TiberiuGC
Copy link
Collaborator

Description

Since we have disabled IMDSv1 by default, we need to retrieve the session token before requesting metadata.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label May 19, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review May 19, 2023 08:19
@TiberiuGC TiberiuGC merged commit a1cd824 into eksctl-io:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiberiuGC @cPu1