Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin K8s dependencies chain to 1.25 #6677

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Pin K8s dependencies chain to 1.25 #6677

merged 3 commits into from
Jul 6, 2023

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Jun 9, 2023 •
edited
Loading

Description

As per a previous decision, we aim to pin the K8s dependencies chain to the default K8s version is eksctl.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added kind/improvement dependencies Pull requests that update a dependency file labels Jun 9, 2023
@TiberiuGC TiberiuGC force-pushed the improvement/pin-k8s-to-1.25 branch from c3cbf5b to 143ed23 Compare June 9, 2023 06:26
@TiberiuGC TiberiuGC added area/tech-debt Leftover improvements in code, testing and building and removed kind/improvement labels Jun 9, 2023
@TiberiuGC TiberiuGC force-pushed the improvement/pin-k8s-to-1.25 branch from 143ed23 to 7725e33 Compare June 9, 2023 08:06
@TiberiuGC TiberiuGC marked this pull request as ready for review June 9, 2023 12:48
@TiberiuGC TiberiuGC requested review from Himangini and cPu1 June 9, 2023 12:48
guessi
guessi reviewed Jun 17, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@TiberiuGC TiberiuGC force-pushed the improvement/pin-k8s-to-1.25 branch from d32d5c5 to cdeab66 Compare June 29, 2023 14:34
Himangini
Himangini approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TiberiuGC TiberiuGC force-pushed the improvement/pin-k8s-to-1.25 branch from 67b3f3a to b96a9d6 Compare July 6, 2023 06:07
@TiberiuGC TiberiuGC merged commit fbb6bd7 into eksctl-io:main Jul 6, 2023
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
@TiberiuGC @IdanShohamNetApp
Pin K8s dependencies chain to 1.25 (eksctl-io#6677)
f31a30e 
* Pin K8s dependencies chain to 1.25

* upgrade to newer 1.25.11 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guessi guessi guessi left review comments

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TiberiuGC @guessi @cPu1 @Himangini