Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Flux Integration #6836

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Cleanup Flux Integration #6836

merged 2 commits into from
Jul 24, 2023

Conversation

TiberiuGC
Copy link
Collaborator

Description

Implementing action items highlighted here.

Closes #6770

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added area/gitops gitops related issues area/tech-debt Leftover improvements in code, testing and building labels Jul 19, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review July 19, 2023 14:02
Himangini
Himangini approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@TiberiuGC TiberiuGC enabled auto-merge (squash) July 24, 2023 04:37
@TiberiuGC TiberiuGC merged commit 34fc38c into eksctl-io:main Jul 24, 2023
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
@TiberiuGC @IdanShohamNetApp
Cleanup Flux Integration (eksctl-io#6836)
90e8713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
area/gitops gitops related issues area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup Flux Integration
2 participants
@TiberiuGC @Himangini