Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PR rebase workflow #6934

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Remove PR rebase workflow #6934

merged 3 commits into from
Aug 9, 2023

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Aug 8, 2023 •
edited
Loading

Description

Removing the workflow as it's not suitable for our main use case. Please refer to #6900 (comment).

Closes #6900

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added area/tech-debt Leftover improvements in code, testing and building technical debt labels Aug 8, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review August 8, 2023 08:55
cPu1
cPu1 reviewed Aug 8, 2023
View reviewed changes
docs/release_notes/0.152.0.md Outdated Show resolved Hide resolved
Himangini
Himangini requested changes Aug 8, 2023
View reviewed changes
docs/release_notes/0.152.0.md Outdated Show resolved Hide resolved
@TiberiuGC TiberiuGC force-pushed the maintenance/remove-pr-rebase-workflow branch from c40973e to 654f258 Compare August 8, 2023 13:10
@TiberiuGC TiberiuGC enabled auto-merge (squash) August 9, 2023 05:56
@TiberiuGC TiberiuGC disabled auto-merge August 9, 2023 05:57
@TiberiuGC TiberiuGC enabled auto-merge (squash) August 9, 2023 05:57
@TiberiuGC TiberiuGC merged commit ea069b0 into eksctl-io:main Aug 9, 2023
10 checks passed
cPu1 pushed a commit to cPu1/eksctl that referenced this pull request Aug 11, 2023
@TiberiuGC @cPu1
Remove PR rebase workflow (eksctl-io#6934)
f744df5
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Aug 24, 2023
@TiberiuGC
Remove PR rebase workflow (eksctl-io#6934)
aa53fe7
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
@TiberiuGC @IdanShohamNetApp
Remove PR rebase workflow (eksctl-io#6934)
d341a2f
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 2, 2024
@TiberiuGC @IdanShohamNetApp
Remove PR rebase workflow (eksctl-io#6934)
e68b18c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

@Himangini Himangini Himangini approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] PR Rebase workflow job is always skipped
4 participants
@TiberiuGC @cPu1 @a-hilaly @Himangini