Set AWS credential expiry window to 30 minutes

[otterley]

Description

Set the AWS credential expiry window to 30 minutes. This will force the AWS client to renew any endpoint-provided credentials (e.g. EC2 instance credentials, ECS-provided credentials) if they would expire in less than 30 minutes, and ensure the passed credentials don't expire during long CloudFormation stack operations.

This PR also includes an update to address a broken reference to pathlib retracted version v1.0.0, replacing it with v0.15.0. (The retracted version was available via the public Go module proxy, but not available directly to those of us who aren't allowed to use the proxy.)

Closes #7095

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the userdocs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes
• (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[TiberiuGC]

Hi @otterley ! Thanks for opening a PR for this improvement.

I realise none of the load options set are being unit tested atm, but I think we can add a test for this one in particular, and improve the overall coverage afterwards. I'll leave a code snipped I came up with rather quickly, so feel free to think of a better way of testing if you wish. (this should be added under pkg/eks/api_test.go)

		// check that load config options were setup properly
		_, options := fakeConfigurationLoader.LoadDefaultConfigArgsForCall(0)
		lo := &config.LoadOptions{}
		for _, loadOptionsFunc := range options {
			Expect(loadOptionsFunc(lo)).NotTo(HaveOccurred())
		}

		// check that credentials cache was setup properly
		cco := &aws.CredentialsCacheOptions{}
		lo.CredentialsCacheOptions(cco)
		Expect(cco.ExpiryWindow).To(Equal(30 * time.Minute))
		Expect(cco.ExpiryWindowJitterFrac).To(Equal(float64(0)))

[otterley]

Hi @TiberiuGC - I'd be happy to do this, but the testing code is a bit difficult for me to make sense of, so I don't know where this would go. Since you already have a sense of where it should go and how it should be composed, I'd welcome your patch - you can submit a PR against this branch and I'll gladly merge it.

[TiberiuGC]

Sure, no worries, I'll update the tests myself.

[otterley]

Thanks @TiberiuGC ! Are we OK to merge?

[TiberiuGC]

@otterley sorry for keeping you waiting, just merged the PR so it will get caught in today's release candidate.