Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor release workflows #7632

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Refactor release workflows #7632

merged 4 commits into from
Mar 14, 2024

Conversation

yuxiang-zhang
Copy link
Member

@yuxiang-zhang yuxiang-zhang commented Mar 1, 2024 •
edited
Loading

Description

  • Replaced goreleaser import with goreleaser GH action
  • Deduped release workflow files (combining release candidate ones with full release ones)

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@yuxiang-zhang yuxiang-zhang added kind/improvement area/tech-debt Leftover improvements in code, testing and building area/ci labels Mar 1, 2024
@yuxiang-zhang yuxiang-zhang force-pushed the enable-brew-pr branch 2 times, most recently from b0805d2 to 14d2048 Compare March 1, 2024 01:58
@yuxiang-zhang yuxiang-zhang marked this pull request as ready for review March 1, 2024 19:57
@yuxiang-zhang yuxiang-zhang changed the title Refactor release workflows Refactor release workflows and move Homebrew Formula to aws/tap Mar 1, 2024
a-hilaly
a-hilaly previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @yuxiang-zhang ! I like that we're removing unnecessary scripts 🙌

go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@yuxiang-zhang yuxiang-zhang changed the title Refactor release workflows and move Homebrew Formula to aws/tap Refactor release workflows Mar 13, 2024
@yuxiang-zhang yuxiang-zhang merged commit 90e16ce into eksctl-io:main Mar 14, 2024
11 checks passed
@yuxiang-zhang yuxiang-zhang deleted the enable-brew-pr branch March 14, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxiang-zhang @a-hilaly