Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a test file to new branch #779

Closed
wants to merge 1 commit into from
Closed

Conversation

MJ2021
Copy link

@MJ2021 MJ2021 commented Mar 27, 2024

This is a draft PR to have discussions regarding specific parts of the code for GSOC

Copy link

google-cla bot commented Mar 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pca006132
Copy link
Collaborator

You can just open a discussion, no need to discuss in a PR with no actual code.

@MJ2021
Copy link
Author

MJ2021 commented Mar 27, 2024

Actually @elalish recommended to create a draft PR which will help to discuss different parts of the code.
Reference : opencax/GSoC#81

@elalish
Copy link
Owner

elalish commented Mar 27, 2024

This is fine, but I'd recommend you at least put some comments in relevant parts of the code you plan to change. The advantage of having the discussion in a PR is that we can easily keep track of multiple threads that are anchored to context in your changed files. You can also start your own comment threads on some of them to draw our attention to questions you have or ideas you'd like vetted.

Also, please update the title to reflect the problem you're planning to solve and reference the issue in the description.

@elalish elalish closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants