Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split boolean tests #792

Merged
merged 8 commits into from
Apr 25, 2024
Merged

Split boolean tests #792

merged 8 commits into from
Apr 25, 2024

Conversation

dasoya
Copy link
Contributor

@dasoya dasoya commented Apr 23, 2024

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't think there's any need to mark this as Draft - we can merge this pretty soon with couple small tweaks. Draft PRs also don't run our full CI checks.

test/boolean_test.cpp Show resolved Hide resolved
test/complex_boolean_test.cpp Outdated Show resolved Hide resolved
@dasoya dasoya marked this pull request as ready for review April 24, 2024 06:52
@dasoya dasoya changed the title Add Boolean fuzz tests & split boolean tests Split boolean tests Apr 24, 2024
@dasoya
Copy link
Contributor Author

dasoya commented Apr 24, 2024

There's a CLA issue because of author's email. I rebased it to change author.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 98.39357% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.51%. Comparing base (d437097) to head (7b48bc6).
Report is 13 commits behind head on master.

Files Patch % Lines
test/complex_boolean_test.cpp 98.43% 3 Missing ⚠️
test/boolean_test.cpp 98.24% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   91.84%   88.51%   -3.33%     
==========================================
  Files          37       57      +20     
  Lines        4976     8098    +3122     
  Branches        0      874     +874     
==========================================
+ Hits         4570     7168    +2598     
- Misses        406      930     +524     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now we just need to do this to manifold_test, which has also grown unreasonably.

@elalish elalish merged commit a8b8bf7 into elalish:master Apr 25, 2024
18 checks passed
@elalish elalish mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants