Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change directory structure #918

Merged
merged 6 commits into from
Sep 10, 2024
Merged

change directory structure #918

merged 6 commits into from
Sep 10, 2024

Conversation

pca006132
Copy link
Collaborator

Closes #701. Closes #917.

  1. Moved every (public) headers into the manifold directory.
  2. Changed public.h to common.h and par.h to parallel.h.
  3. Install parallel.h and iters.h

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (d437097) to head (5e5bbcf).
Report is 88 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   91.84%   88.40%   -3.44%     
==========================================
  Files          37       62      +25     
  Lines        4976     8660    +3684     
  Branches        0     1059    +1059     
==========================================
+ Hits         4570     7656    +3086     
- Misses        406     1004     +598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzeller
Copy link
Contributor

hzeller commented Sep 8, 2024

Nice! LGTM.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. My only thoughts, and I'm not at all sure these are good, is would it be nice if all the public manifold headers were in the same directory? Or is that confusing? And likewise, would it be helpful to separate the public headers like common.h from the internal headers like vec.h into different directories?

@pca006132
Copy link
Collaborator Author

Separating the headers sounds good, but I am not sure how to do this with our current module organization. Having 2 header directories in the same module seems a bit too cluttered to me. Anyway, that will not be public facing changes, so it should be fine to do it later I guess.

@hzeller
Copy link
Contributor

hzeller commented Sep 10, 2024

maybe there could be an internal/ subdirectory. But also agree, that can be refined later.

@elalish elalish merged commit 9124a68 into elalish:master Sep 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Parallel Algorithms header file naming/directory structure
3 participants