-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change directory structure #918
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 91.84% 88.40% -3.44%
==========================================
Files 37 62 +25
Lines 4976 8660 +3684
Branches 0 1059 +1059
==========================================
+ Hits 4570 7656 +3086
- Misses 406 1004 +598 ☔ View full report in Codecov by Sentry. |
Nice! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. My only thoughts, and I'm not at all sure these are good, is would it be nice if all the public manifold headers were in the same directory? Or is that confusing? And likewise, would it be helpful to separate the public headers like common.h
from the internal headers like vec.h
into different directories?
Separating the headers sounds good, but I am not sure how to do this with our current module organization. Having 2 header directories in the same module seems a bit too cluttered to me. Anyway, that will not be public facing changes, so it should be fine to do it later I guess. |
maybe there could be an |
Closes #701. Closes #917.
manifold
directory.public.h
tocommon.h
andpar.h
toparallel.h
.parallel.h
anditers.h