Log cloud metadata provider failures at trace level (#1338)

This commit logs the cloud metadata provider failures at the trace level and adds more detail to the log message. Closes #1283
elastic · Jun 18, 2021 · 2368354 · 2368354
1 parent 708ece0
commit 2368354
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/src/Elastic.Apm/Cloud/AwsCloudMetadataProvider.cs b/src/Elastic.Apm/Cloud/AwsCloudMetadataProvider.cs
@@ -82,7 +82,9 @@ internal AwsCloudMetadataProvider(IApmLogger logger, HttpMessageHandler handler)
 			}
 			catch (Exception e)
 			{
-				_logger.Info()?.LogException(e, "Unable to get {Provider} cloud metadata", Provider);
+				_logger.Trace()?.LogException(
+					e,
+					"Unable to get {Provider} cloud metadata. The application is likely not running in {Provider}", Provider);
 				return null;
 			}
 		}

diff --git a/src/Elastic.Apm/Cloud/AzureAppServiceMetadataProvider.cs b/src/Elastic.Apm/Cloud/AzureAppServiceMetadataProvider.cs
@@ -63,7 +63,7 @@ bool NullOrEmptyVariable(string key, string value)
 				if (!string.IsNullOrEmpty(value)) return false;
 
 				_logger.Trace()?.Log(
-					"Unable to get {Provider} cloud metadata as no {EnvironmentVariable} environment variable",
+					"Unable to get {Provider} cloud metadata as no {EnvironmentVariable} environment variable. The application is likely not running in {Provider}",
 					Provider,
 					key);
 

diff --git a/src/Elastic.Apm/Cloud/AzureCloudMetadataProvider.cs b/src/Elastic.Apm/Cloud/AzureCloudMetadataProvider.cs
@@ -73,7 +73,9 @@ internal AzureCloudMetadataProvider(IApmLogger logger, HttpMessageHandler handle
 			}
 			catch (Exception e)
 			{
-				_logger.Info()?.LogException(e, "Unable to get {Provider} cloud metadata", Provider);
+				_logger.Trace()?.LogException(
+					e,
+					"Unable to get {Provider} cloud metadata. The application is likely not running in {Provider}", Provider);
 				return null;
 			}
 		}

diff --git a/src/Elastic.Apm/Cloud/GcpCloudMetadataProvider.cs b/src/Elastic.Apm/Cloud/GcpCloudMetadataProvider.cs
@@ -93,7 +93,9 @@ internal GcpCloudMetadataProvider(IApmLogger logger, HttpMessageHandler handler)
 			}
 			catch (Exception e)
 			{
-				_logger.Info()?.LogException(e, "Unable to get {Provider} cloud metadata", Provider);
+				_logger.Trace()?.LogException(
+					e,
+					"Unable to get {Provider} cloud metadata. The application is likely not running in {Provider}", Provider);
 				return null;
 			}
 		}