Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 424] Public API extended by destination fields #916

Closed
AlexanderWert opened this issue Mar 15, 2021 · 2 comments · Fixed by #931
Closed

[META 424] Public API extended by destination fields #916

AlexanderWert opened this issue Mar 15, 2021 · 2 comments · Fixed by #931
Assignees
@axw
Labels
agent-go
Milestone
7.13

Comments

@AlexanderWert
Copy link
Member

Extend the public API of the agent to allow setting destination fields as described in elastic/apm#424 .
@AlexanderWert AlexanderWert added this to the 7.13 milestone Mar 15, 2021
@AlexanderWert AlexanderWert mentioned this issue Mar 15, 2021
Closed
@axw
Copy link
Member

axw commented Mar 15, 2021

This is already done except for cloud region, just need to add that.

@axw
Copy link
Member

axw commented Mar 18, 2021

It was just discovered in https://discuss.elastic.co/t/data-validation-error-from-traefik-go-agent-to-elastic-apm-server/267614 that we send destination context even when some fields are unspecified, which leads to a validation error. In this case we should not send the context, as described at elastic/apm#424 (comment)

@axw axw self-assigned this Apr 12, 2021
@axw axw mentioned this issue Apr 12, 2021
Merged
@axw axw closed this as completed in #931 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axw axw

Labels
agent-go
Projects
None yet
Milestone
7.13
Development

Successfully merging a pull request may close this issue.

Require non-empty values in SetDestinationService axw/apm-agent-go
2 participants
@axw @AlexanderWert