Require non-empty values in SetDestinationService #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetDestinationService must not send an empty Name if a non-empty Resource is specified (and vice versa), as this will lead to a validation error in apm-server. Change SetDestinationService to set neither if either one is empty.
axw
force-pushed
the
destinationservice-validation
branch
from
f7ec08d to
1b91d8c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Apr 13, 2021
stuartnelson3
pushed a commit
that referenced
this pull request
Jul 30, 2021
SetDestinationService must not send an empty Name if a non-empty Resource is specified (and vice versa), as this will lead to a validation error in apm-server. Change SetDestinationService to set neither if either one is empty.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
SpanContext.SetDestinationServiceto be a no-op if either Name or Resource is empty. We must not send an empty Name if a non-empty Resource is specified (and vice versa), as this will lead to a validation error in apm-server.Closes #916