[apmazure] add blob storage #1105
Conversation
Structure is: <Storage Account Name>.blob.core.windows.net We could parse it to get storage-account-name + service (blob, in this case), but the information also seems to be available in the path of the constructed url.
This reverts commit 33bc894.
Some of the azure go sdk modules require go1.14
go vet fails when run on a directory with no buildable files, eg. running go vet with a version of go too low for the provided dir.
solves the problem when we are attempting to go vet a module, but the version of go we are using isn't supported.
This reverts commit 48d00e6.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
module/apmazure/blob_test.go
Outdated
| // TODO: If we use a fake URL, the test is fast but we do not set a | ||
| // status code |
There was a problem hiding this comment.
why don't we set a status code? can we not use an httptest server?
There was a problem hiding this comment.
Because the request errors, resp.Response() is nil, so we can't get a status code. We could use something like example.blob.core.windows.net and get a 4XX response, but then the test takes a while longer (~1sec).
If we use httptest.Server, the URL is a local IP addr, but we rely on the subdomains in the provided url to get the account name and storage type (blob, queue, eg): https://fakeaccnt.blob.core.windows.net. We could use an httptest server and check the status code is set correctly, but then we won't be able to parse out (in this case) fakeaccnt and blob for other span properties.
There was a problem hiding this comment.
I see. What about setting PipelineOptions.HTTPSender, and skipping the net/http stack altogether?
Add azure blob storage instrumentation.
I added instrumentation for azurequeue and moved the code into the interface seen in this PR, and then realized I was using the wrong azure lib. I decided to just bring over the interface from the other code for now.
There are still 3 other azure storage services to implement before #885 is officially "done":