Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apmazure] storage queue #1107

Merged
merged 41 commits into from
Aug 24, 2021
Merged

[apmazure] storage queue #1107

merged 41 commits into from
Aug 24, 2021

Conversation

stuartnelson3
Copy link
Contributor

Add azure queue storage instrumentation.

There are still 2 other azure storage services to implement before #885 is officially "done":

  • Table
  • File Storage

@stuartnelson3
add azure blob storage instrumentation
12ff5c7
@stuartnelson3
Use a "real" azure url
1cc7e97 
Structure is:

<Storage Account Name>.blob.core.windows.net

We could parse it to get storage-account-name +
service (blob, in this case), but the information
also seems to be available in the path of the
constructed url.
@stuartnelson3
go mod tidy
33bc894
@stuartnelson3
update dockerfile-testing
dae9391
@stuartnelson3
update docs
1c7d182
@stuartnelson3
Revert "go mod tidy"
e059db6 
This reverts commit 33bc894.
@stuartnelson3
tidy the right mods
7795683
@stuartnelson3
update go.mod:wq
069b9e1
@stuartnelson3
Merge branch 'master' into azure-storage
735750d
@stuartnelson3
drop version req
01f7dea
@stuartnelson3
Add build constraints
5a92a9c 
Some of the azure go sdk modules require go1.14
@stuartnelson3
add apmazure doc.go
ec86c40 
go vet fails when run on a directory with no
buildable files, eg. running go vet with a version
of go too low for the provided dir.
@stuartnelson3
ignore modules with no buildable go files
48d00e6 
solves the problem when we are attempting to go
vet a module, but the version of go we are using
isn't supported.
@stuartnelson3
Revert "ignore modules with no buildable go files"
c0b3aea 
This reverts commit 48d00e6.
@stuartnelson3
Merge branch 'master' into azure-storage
829ef0a
@stuartnelson3
goimports
78c15f3
@stuartnelson3
remove dead comment
1c98ac7
@stuartnelson3
introduce azureRPC interface
5fb2d47
@stuartnelson3
implement using correct blob storage lib
93edb8b
@stuartnelson3
Update instrumenting.asciidoc
f8f02a4
@stuartnelson3
update supported-tech.asciidoc
cc953b4
@stuartnelson3
use GetTags method
4bb5dc2
@stuartnelson3
Merge branch 'azure-storage' into azure-storage-queue
730e2c5
@stuartnelson3
create queue in newAzureRPC
956c13a
@stuartnelson3
add send and http verb tests
922adef
@stuartnelson3
add test for receiving from queue
cbe0431 
receive/send were reversed in the tests. fix the
naming, and verify that receiving a message starts
a new tx.
@stuartnelson3
pr comments
082da6f
@stuartnelson3
Merge branch 'master' into azure-storage
3de8927
@stuartnelson3
Merge branch 'azure-storage' into azure-storage-queue
fb2e674
@stuartnelson3
remove comment/test for deprecated features
0f85740
@stuartnelson3 stuartnelson3 requested a review from a team August 23, 2021 08:35
@stuartnelson3 stuartnelson3 marked this pull request as draft August 23, 2021 08:36
@stuartnelson3 stuartnelson3 marked this pull request as ready for review August 23, 2021 08:38
@apmmachine
Copy link
Contributor

apmmachine commented Aug 23, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-24T11:21:21.390+0000

  • Duration: 30 min 59 sec

  • Commit: f839e59

Test stats 🧪

Test Results
Failed 0
Passed 10964
Skipped 268
Total 11232

Trends 🧪

Image of Build Times

Image of Tests

axw
axw reviewed Aug 24, 2021
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one issue about testing of the queue instrumentation, otherwise LGTM. I didn't verify the spec is being adhered to exactly, I'll take your word on that.

module/apmazure/blob.go Show resolved Hide resolved
module/apmazure/blob.go Show resolved Hide resolved
module/apmazure/queue_test.go Outdated Show resolved Hide resolved
@stuartnelson3
Copy link
Contributor Author

/test

@stuartnelson3
Copy link
Contributor Author

jenkins run the tests

1 similar comment
@stuartnelson3
Copy link
Contributor Author

jenkins run the tests

@stuartnelson3 stuartnelson3 merged commit 4173391 into elastic:master Aug 24, 2021
@stuartnelson3 stuartnelson3 deleted the azure-storage-queue branch August 24, 2021 13:13
@stuartnelson3 stuartnelson3 mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw left review comments

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartnelson3 @apmmachine @axw