Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apmazure] storage file #1108

Closed
wants to merge 36 commits into from

Conversation

stuartnelson3
Copy link
Contributor

@stuartnelson3 stuartnelson3 commented Aug 23, 2021

Add azure file storage instrumentation.

Table Service still needs to be implemented before #885 is officially "done".

Structure is:

<Storage Account Name>.blob.core.windows.net

We could parse it to get storage-account-name +
service (blob, in this case), but the information
also seems to be available in the path of the
constructed url.
This reverts commit 33bc894.
Some of the azure go sdk modules require go1.14
go vet fails when run on a directory with no
buildable files, eg. running go vet with a version
of go too low for the provided dir.
solves the problem when we are attempting to go
vet a module, but the version of go we are using
isn't supported.
receive/send were reversed in the tests. fix the
naming, and verify that receiving a message starts
a new tx.
@apmmachine
Copy link
Contributor

apmmachine commented Aug 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-23T14:12:23.500+0000

  • Duration: 32 min 32 sec

  • Commit: a83eb66

Test stats 🧪

Test Results
Failed 0
Passed 11011
Skipped 268
Total 11279

Trends 🧪

Image of Build Times

Image of Tests

@stuartnelson3 stuartnelson3 deleted the azure-storage-file branch August 24, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants