-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared JSON spec for span types/subtypes #1812
Shared JSON spec for span types/subtypes #1812
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
…gent-java into span-type-subtype-spec
See elastic/apm#443 PR for adding this to shared specifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few minor comments and one question about the spec itself - for a given type, is null
subtype allowed when the spec defines a list of subtypes?
* Sets all optional checks to their default value (enabled), should be used as a shortcut to reset mock reporter state | ||
* after/before using it for a single test execution | ||
*/ | ||
public void resetChecks() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
...ent-plugins/apm-process-plugin/src/main/java/co/elastic/apm/agent/process/ProcessHelper.java
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/MockReporter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One minor suggestion
Description
Creates and enforces JSON spec for all the span types/subtypes that are used in the Java agent
This is a preliminary step to having a shared spec applied to all APM agents.
Related PR for all agents : elastic/apm#443
Checklist
foo.*
type.null
(not provided) or""
(empty) sub-types:Solution (1): normalize tonull
instead of empty and treatsub-type
as optionalnull
instead of empty and allownull
on some types (not all of them).process
type that uses binary name as sub-type (or find a proper way to fix it).subtype
that was using binary name, it's already provided inname
template
type that uses template engine name as sub-type (and is also very platform-specific)type
and notsubtype
as it's really platform-specificcache.redis
todb.redis
for consistencycustom
as default span type instead ofunknown