-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for setting the framework using the public api (#1908) #1909
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Thanks for this PR @tobiasstadler ! Some things are missing:
You can see examples for all of those in #1788 |
@eyalkoren I did the requested changes The javadoc/documentation states
In my opinion this clearly says that a user set value has a higher precedence that an automatic set value (by a plugin). Do you agree? |
Absolutely agree, only a word that setting |
run elasticsearch-ci/docs |
Thank You! |
Thank YOU! 😄 |
* master: Bump version.slf4j from 1.7.31 to 1.7.32 (elastic#1933) Add description about memory pool metrics to docs (elastic#1925) updated team membership check in action Add 1.25.0 to cloudfoundry index Update CHANGELOG.asciidoc (elastic#1929) fixed community label action [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release v1.25.0 Prepare release 1.25.0 (elastic#1927) synchronize json schema specs (elastic#1926) added labeling of community issues and PRs added community labeler config Upgrade Byte Buddy to 1.11.8 (elastic#1923) Bump json-schema-validator from 1.0.56 to 1.0.57 (elastic#1916) Bump log4j2-ecs-layout from 1.0.1 to 1.1.0 (elastic#1917) Added support for setting the framework using the public api (elastic#1908) (elastic#1909) Add Javalin plugin (elastic#1822)
What does this PR do?
Fixes #1908
Checklist