Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align span subtype for SqlServer #2112

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Sep 8, 2021

What does this PR do?

Align Java agent span subtype for MS SqlServer

This is a small breaking change as anyone relying on span type/subtype might have to adapt to the new value.

Relates to elastic/apm#502

Checklist

  • This is a bugfix

@apmmachine
Copy link
Contributor

apmmachine commented Sep 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-13T09:28:04.822+0000

  • Duration: 59 min 44 sec

  • Commit: cc34a71

Test stats 🧪

Test Results
Failed 0
Passed 2396
Skipped 19
Total 2415

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2396
Skipped 19
Total 2415

@SylvainJuge SylvainJuge force-pushed the span-subtype-sqlserver branch from bcc957d to 9d4ddf8 Compare September 8, 2021 13:15
@AlexanderWert AlexanderWert added this to the 7.16 milestone Sep 13, 2021
@SylvainJuge SylvainJuge merged commit 8f771d9 into elastic:master Sep 13, 2021
@SylvainJuge SylvainJuge deleted the span-subtype-sqlserver branch September 13, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants